Changeset 34607 in webkit for trunk/JavaScriptCore/API/JSObjectRef.cpp

Timestamp:

Jun 16, 2008, 4:28:38 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Geoff Garen.

Make Identifier construction use an explicitly passed IdentifierTable.

No change on SunSpider total.

File:

• trunk/JavaScriptCore/API/JSObjectRef.cpp (modified) (8 diffs)

trunk/JavaScriptCore/API/JSObjectRef.cpp

@@ -88 +88 @@
     JSLock lock;
     ExecState* exec = toJS(ctx);
-    Identifier nameID = name ? Identifier(toJS(name)) : Identifier("anonymous");
+    Identifier nameID = name ? Identifier(exec, toJS(name)) : Identifier(exec, "anonymous");
     
     return toRef(new JSCallbackFunction(exec, callAsFunction, nameID));
@@ -115 +115 @@
     UString::Rep* sourceURLRep = sourceURL ? toJS(sourceURL) : &UString::Rep::null;
     
-    Identifier nameID = name ? Identifier(toJS(name)) : Identifier("anonymous");
+    Identifier nameID = name ? Identifier(exec, toJS(name)) : Identifier(exec, "anonymous");
     
     ArgList args;
@@ -153 +153 @@
     UString::Rep* nameRep = toJS(propertyName);
     
-    return jsObject->hasProperty(exec, Identifier(nameRep));
+    return jsObject->hasProperty(exec, Identifier(exec, nameRep));
 }
 
@@ -163 +163 @@
     UString::Rep* nameRep = toJS(propertyName);
 
-    JSValue* jsValue = jsObject->get(exec, Identifier(nameRep));
+    JSValue* jsValue = jsObject->get(exec, Identifier(exec, nameRep));
     if (exec->hadException()) {
         if (exception)
@@ -177 +177 @@
     ExecState* exec = toJS(ctx);
     JSObject* jsObject = toJS(object);
-    Identifier name(toJS(propertyName));
+    Identifier name(exec, toJS(propertyName));
     JSValue* jsValue = toJS(value);
 
@@ -230 +230 @@
     UString::Rep* nameRep = toJS(propertyName);
 
-    bool result = jsObject->deleteProperty(exec, Identifier(nameRep));
+    bool result = jsObject->deleteProperty(exec, Identifier(exec, nameRep));
     if (exec->hadException()) {
         if (exception)
@@ -325 +325 @@
 struct OpaqueJSPropertyNameArray
 {
-    OpaqueJSPropertyNameArray() : refCount(0)
+    OpaqueJSPropertyNameArray(JSGlobalData* globalData) : refCount(0), array(globalData)
     {
     }
@@ -339 +339 @@
     ExecState* exec = toJS(ctx);
     
-    JSPropertyNameArrayRef propertyNames = new OpaqueJSPropertyNameArray();
+    JSPropertyNameArrayRef propertyNames = new OpaqueJSPropertyNameArray(&exec->globalData());
     jsObject->getPropertyNames(exec, propertyNames->array);