Changeset 34610 in webkit for trunk/JavaScriptCore/kjs/JSVariableObject.h

Timestamp:

Jun 16, 2008, 7:49:07 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-16 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Slight cleanup to the SymbolTableEntry class.

Renamed isEmpty to isNull, since we usually use "empty" to mean "holds
the valid, empty value", and "null" to mean "holds no value".

Changed an "== 0" to a "!", to match our style guidelines.

Added some ASSERTs to verify the (possibly questionable) assumption that
all register indexes will have their high two bits set. Also clarified a
comment to make that assumption clear.

File:

• trunk/JavaScriptCore/kjs/JSVariableObject.h (modified) (4 diffs)

trunk/JavaScriptCore/kjs/JSVariableObject.h

@@ -101 +101 @@
     {
         SymbolTableEntry entry = symbolTable().inlineGet(propertyName.ustring().rep());
-        if (!entry.isEmpty()) {
+        if (!entry.isNull()) {
             slot.setValueSlot(&valueAt(entry.getIndex()));
             return true;
@@ -111 +111 @@
     {
         SymbolTableEntry entry = symbolTable().inlineGet(propertyName.ustring().rep());
-        if (!entry.isEmpty()) {
+        if (!entry.isNull()) {
             slot.setValueSlot(&valueAt(entry.getIndex()));
             slotIsWriteable = !entry.isReadOnly();
@@ -122 +122 @@
     {
         SymbolTableEntry entry = symbolTable().inlineGet(propertyName.ustring().rep());
-        if (entry.isEmpty())
+        if (entry.isNull())
             return false;
         if (entry.isReadOnly())
@@ -136 +136 @@
             return false;
         SymbolTableEntry& entry = iter->second;
-        ASSERT(!entry.isEmpty());
+        ASSERT(!entry.isNull());
         entry.setAttributes(attributes);
         valueAt(entry.getIndex()) = value;