Changeset 34758 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.cpp

Timestamp:

Jun 24, 2008, 2:38:40 AM (17 years ago)

Author:

[email protected]

Message:

2008-06-24 Cameron Zwarich <​[email protected]>

Reviewed by Oliver.

Bug 19730: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
<​https://bugs.webkit.org/show_bug.cgi?id=19730>

Do not convert the pair (less, jtrue) to jless when jtrue is a jump
target. An example of this is when the condition of a while loop is a
LogicalOrNode.

JavaScriptCore:

• VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitLabel):

LayoutTests:

• fast/js/codegen-loops-logical-nodes-expected.txt: Added.
• fast/js/codegen-loops-logical-nodes.html: Added.
• fast/js/resources/codegen-loops-logical-nodes.js: Added.

File:

• trunk/JavaScriptCore/VM/CodeGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -391 +391 @@
 {
     l0->setLocation(instructions().size());
+    
+    // This disables peephole optimizations when an instruction is a jump target
+    m_lastOpcodeID = op_end;
+    
     return l0;
 }