Changeset 34858 in webkit for trunk/JavaScriptCore/VM/Machine.cpp

Timestamp:

Jun 28, 2008, 3:21:20 PM (17 years ago)

Author:

Darin Adler

Message:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

• ​https://bugs.webkit.org/show_bug.cgi?id=19801 add a feature so we can tell what regular expressions are taking time

• pcre/pcre_compile.cpp: (jsRegExpCompile): Compile in the string if REGEXP_HISTOGRAM is on.

• pcre/pcre_exec.cpp: (jsRegExpExecute): Add hook to time execution. (Histogram::~Histogram): Print a sorted list of what took time. (Histogram::add): Accumulate records of what took time. (HistogramTimeLogger::~HistogramTimeLogger): Hook that calls Histogram::add at the right moment and creates the global histogram object.

• pcre/pcre_internal.h: Define REGEXP_HISTOGRAM.

• pcre/pcre_tables.cpp: Added missing include of "config.h". Not needed any more, but an omissions an earlier version of this patch detected.
• pcre/pcre_ucp_searchfuncs.cpp: Ditto.
• pcre/pcre_xclass.cpp: Ditto.

File:

• trunk/JavaScriptCore/VM/Machine.cpp (modified) (1 diff)

trunk/JavaScriptCore/VM/Machine.cpp

@@ -888 +888 @@
 // It doesn't matter what "current time" is here, just as long as
 // it's possible to measure the time difference correctly.
-// In an ideal world this would be in DateMath or some such, but unfortunately
-// that's a regression.
+// In an ideal world this would just be getCurrentUTCTimeWithMicroseconds
+// from DateMath.h, but unfortunately there's a slowdown if we use tha.
 static inline unsigned getCurrentTime()
 {