Changeset 34858 in webkit for trunk/JavaScriptCore/pcre/pcre_internal.h

Timestamp:

Jun 28, 2008, 3:21:20 PM (17 years ago)

Author:

Darin Adler

Message:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

• ​https://bugs.webkit.org/show_bug.cgi?id=19801 add a feature so we can tell what regular expressions are taking time

• pcre/pcre_compile.cpp: (jsRegExpCompile): Compile in the string if REGEXP_HISTOGRAM is on.

• pcre/pcre_exec.cpp: (jsRegExpExecute): Add hook to time execution. (Histogram::~Histogram): Print a sorted list of what took time. (Histogram::add): Accumulate records of what took time. (HistogramTimeLogger::~HistogramTimeLogger): Hook that calls Histogram::add at the right moment and creates the global histogram object.

• pcre/pcre_internal.h: Define REGEXP_HISTOGRAM.

• pcre/pcre_tables.cpp: Added missing include of "config.h". Not needed any more, but an omissions an earlier version of this patch detected.
• pcre/pcre_ucp_searchfuncs.cpp: Ditto.
• pcre/pcre_xclass.cpp: Ditto.

File:

• trunk/JavaScriptCore/pcre/pcre_internal.h (modified) (3 diffs)

trunk/JavaScriptCore/pcre/pcre_internal.h

@@ -70 +70 @@
 #ifndef DFTABLES
 
+// Change the following to 1 to dump used regular expressions at process exit time.
+#define REGEXP_HISTOGRAM 0
+
 #include "Assertions.h"
 
@@ -316 +319 @@
 #define EXTRACT_BASIC_MAX  100
 
-/* The index of names and the
-code vector run on as long as necessary after the end. We store an explicit
-offset to the name table so that if a regex is compiled on one host, saved, and
-then run on another where the size of pointers is different, all might still
-be well. For the case of compiled-on-4 and run-on-8, we include an extra
-pointer that is always NULL.
-*/
+/* The code vector runs on as long as necessary after the end. */
 
 struct JSRegExp {
@@ -332 +329 @@
     unsigned short firstByte;
     unsigned short reqByte;
+
+#if REGEXP_HISTOGRAM
+    size_t stringOffset;
+    size_t stringLength;
+#endif
 };