Changeset 34868 in webkit for trunk/JavaScriptCore/JavaScriptCore.exp

Timestamp:

Jun 28, 2008, 10:38:37 PM (17 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=19805 Array.concat turns missing array elements into "undefined"

Test: fast/js/array-holes.html

• JavaScriptCore.exp: No longer export JSArray::getItem.

• kjs/ArrayPrototype.cpp: (KJS::arrayProtoFuncConcat): Changed to use getProperty instead of JSArray::getItem -- need to handle properties from the prototype chain instead of ignoring them.

• kjs/JSArray.cpp: Removed getItem.
• kjs/JSArray.h: Ditto.

WebCore:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=19805 Array.concat turns missing array elements into "undefined"

• bridge/jni/jni_utility.cpp: (KJS::Bindings::convertArrayInstanceToJavaArray): Use get instead of getItem, since we always want to consider values from the prototypes when looking at JavaScript arrays.

LayoutTests:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

• test for ​https://bugs.webkit.org/show_bug.cgi?id=19805 Array.concat turns missing array elements into "undefined"

• fast/js/array-holes-expected.txt: Added.
• fast/js/array-holes.html: Added.
• fast/js/resources/array-holes.js: Added.

File:

• trunk/JavaScriptCore/JavaScriptCore.exp (modified) (1 diff)

trunk/JavaScriptCore/JavaScriptCore.exp

@@ -277 +277 @@
 __ZNK3KJS6JSCell9getUInt32ERj
 __ZNK3KJS7ArgList8getSliceEiRS0_
-__ZNK3KJS7JSArray7getItemEj
 __ZNK3KJS7JSValue15toInt32SlowCaseEPNS_9ExecStateERb
 __ZNK3KJS7JSValue16toUInt32SlowCaseEPNS_9ExecStateERb