Changeset 34906 in webkit for trunk/JavaScriptCore/VM/Machine.h

Timestamp:

Jun 30, 2008, 10:45:21 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-30 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.

SunSpider says 0.8% faster.

File:

• trunk/JavaScriptCore/VM/Machine.h (modified) (2 diffs)

trunk/JavaScriptCore/VM/Machine.h

@@ -96 +96 @@
         JSValue* retrieveCaller(ExecState*, JSFunction*) const;
 
-        void getFunctionAndArguments(Register** registerBase, Register* callFrame, JSFunction*&, Register*& argv, int& argc);
+        void getArgumentsData(Register* callFrame, JSFunction*&, Register*& argv, int& argc);
         void setTimeoutTime(unsigned timeoutTime) { m_timeoutTime = timeoutTime; }
         
@@ -127 +127 @@
 
         ALWAYS_INLINE void setScopeChain(ExecState* exec, ScopeChainNode*&, ScopeChainNode*);
-        NEVER_INLINE void debug(ExecState*, const Instruction*, const CodeBlock*, ScopeChainNode*, Register**, Register*);
+        NEVER_INLINE void debug(ExecState*, const Instruction*, const CodeBlock*, ScopeChainNode*, Register*);
 
-        NEVER_INLINE bool unwindCallFrame(ExecState*, JSValue*, Register**, const Instruction*&, CodeBlock*&, JSValue**&, ScopeChainNode*&, Register*&);
-        NEVER_INLINE Instruction* throwException(ExecState*, JSValue*, Register**, const Instruction*, CodeBlock*&, JSValue**&, ScopeChainNode*&, Register*&);
+        NEVER_INLINE bool unwindCallFrame(ExecState*, JSValue*, const Instruction*&, CodeBlock*&, JSValue**&, ScopeChainNode*&, Register*&);
+        NEVER_INLINE Instruction* throwException(ExecState*, JSValue*, const Instruction*, CodeBlock*&, JSValue**&, ScopeChainNode*&, Register*&);
 
-        bool getCallFrame(ExecState*, JSFunction*, Register**& registerBase, int& callFrameOffset) const;
+        Register* callFrame(ExecState*, JSFunction*) const;
 
         JSValue* privateExecute(ExecutionFlag, ExecState* = 0, RegisterFile* = 0, Register* = 0, ScopeChainNode* = 0, CodeBlock* = 0, JSValue** exception = 0);