Changeset 34906 in webkit for trunk/JavaScriptCore/kjs/JSActivation.cpp

Timestamp:

Jun 30, 2008, 10:45:21 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-30 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.

SunSpider says 0.8% faster.

File:

• trunk/JavaScriptCore/kjs/JSActivation.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/JSActivation.cpp

@@ -39 +39 @@
 const ClassInfo JSActivation::info = { "JSActivation", 0, 0, 0 };
 
-JSActivation::JSActivation(PassRefPtr<FunctionBodyNode> functionBody, Register** registerBase, int registerOffset)
-    : Base(new JSActivationData(functionBody, registerBase, registerOffset))
+JSActivation::JSActivation(PassRefPtr<FunctionBodyNode> functionBody, Register* registers)
+    : Base(new JSActivationData(functionBody, registers))
 {
 }
@@ -55 +55 @@
         return;
 
-    copyRegisterArray(registers() - numLocals, numLocals);
+    copyRegisterArray(d()->registers - numLocals, numLocals);
 }
 
@@ -156 +156 @@
 JSObject* JSActivation::createArgumentsObject(ExecState* exec)
 {
-    Register* callFrame = registers() - d()->functionBody->generatedCode().numLocals - RegisterFile::CallFrameHeaderSize;
+    Register* callFrame = d()->registers - d()->functionBody->generatedCode().numLocals - RegisterFile::CallFrameHeaderSize;
 
     JSFunction* function;
     Register* argv;
     int argc;
-    exec->machine()->getFunctionAndArguments(registerBase(), callFrame, function, argv, argc);
-    ArgList args(reinterpret_cast<JSValue***>(registerBase()), argv - *registerBase(), argc);
+    exec->machine()->getArgumentsData(callFrame, function, argv, argc);
+
+    ArgList args(reinterpret_cast<JSValue**>(argv), argc);
     return new (exec) Arguments(exec, function, args, this);
 }