Changeset 34906 in webkit for trunk/JavaScriptCore/kjs/JSGlobalObject.h

Timestamp:

Jun 30, 2008, 10:45:21 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-30 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.

SunSpider says 0.8% faster.

File:

• trunk/JavaScriptCore/kjs/JSGlobalObject.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSGlobalObject.h

@@ -75 +75 @@
         struct JSGlobalObjectData : public JSVariableObjectData {
             JSGlobalObjectData(JSGlobalObject* globalObject, JSObject* thisValue)
-                : JSVariableObjectData(&symbolTable, 0, 0)
+                : JSVariableObjectData(&symbolTable, 0)
                 , globalScopeChain(globalObject, thisValue)
             {
@@ -259 +259 @@
     inline void JSGlobalObject::addStaticGlobals(GlobalPropertyInfo* globals, int count)
     {
-        int numGlobals = d()->registerOffset;
-        Register* registerArray = static_cast<Register*>(fastMalloc((numGlobals + count) * sizeof(Register)));
+        size_t registerArraySize = d()->registerArraySize;
+        Register* registerArray = static_cast<Register*>(fastMalloc((registerArraySize + count) * sizeof(Register)));
         if (d()->registerArray)
-            memcpy(registerArray + count, d()->registerArray, numGlobals * sizeof(Register));
-        setRegisterArray(registerArray, numGlobals + count);
-
-        for (int i = 0, index = -numGlobals - 1; i < count; ++i, --index) {
+            memcpy(registerArray + count, d()->registerArray.get(), registerArraySize * sizeof(Register));
+        setRegisterArray(registerArray, registerArraySize + count);
+
+        for (int i = 0, index = -registerArraySize - 1; i < count; ++i, --index) {
             GlobalPropertyInfo& global = globals[i];
             ASSERT(global.attributes & DontDelete);