Changeset 34906 in webkit for trunk/JavaScriptCore/kjs/JSVariableObject.cpp

Timestamp:

Jun 30, 2008, 10:45:21 PM (17 years ago)

Author:

[email protected]

Message:

2008-06-30 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.

SunSpider says 0.8% faster.

File:

• trunk/JavaScriptCore/kjs/JSVariableObject.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSVariableObject.cpp

@@ -71 +71 @@
         return;
     
-    Register* end = d->registerArray + d->registerOffset;
-    for (Register* it = d->registerArray; it != end; ++it) {
+    Register* end = d->registerArray.get() + d->registerArraySize;
+    for (Register* it = d->registerArray.get(); it != end; ++it) {
         JSValue* v = (*it).u.jsValue;
         if (!v->marked())
@@ -96 +96 @@
 void JSVariableObject::setRegisterArray(Register* registerArray, size_t count)
 {
-    delete d->registerArray;
-    d->registerArray = registerArray;
-    d->registerBase = &d->registerArray;
-    d->registerOffset = count;
+    d->registerArray.set(registerArray);
+    d->registerArraySize = count;
+    d->registers = registerArray + count;
 }