Changeset 34964 in webkit for trunk/JavaScriptCore/kjs/JSArray.cpp

Timestamp:

Jul 2, 2008, 5:47:00 PM (17 years ago)

Author:

[email protected]

Message:

2008-07-02 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Optimized a[n] get for cases where a is an array or a string, and a[n]
put for cases where a is an array.

SunSpider says 9.0% faster.

File:

• trunk/JavaScriptCore/kjs/JSArray.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSArray.cpp

@@ -35 +35 @@
 namespace KJS {
 
-typedef HashMap<unsigned, JSValue*> SparseArrayValueMap;
-
-struct ArrayStorage {
-    unsigned m_vectorLength;
-    unsigned m_numValuesInVector;
-    SparseArrayValueMap* m_sparseValueMap;
-    void* lazyCreationData; // An JSArray subclass can use this to fill the vector lazily.
-    JSValue* m_vector[1];
-};
-
 // 0xFFFFFFFF is a bit weird -- is not an array index even though it's an integer.
 static const unsigned maxArrayIndex = 0xFFFFFFFEU;
@@ -82 +72 @@
 #endif
 
-JSArray::JSArray(JSObject* prototype, unsigned initialLength)
+JSArray::JSArray(JSValue* prototype, unsigned initialLength)
     : JSObject(prototype)
 {