Changeset 35097 in webkit for trunk/JavaScriptCore/kjs/InitializeThreading.cpp

Timestamp:

Jul 10, 2008, 10:55:26 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Mark Rowe.

Eliminate CollectorHeapIntrospector.

CollectorHeapIntrospector was added primarily in the hopes to improve leaks tool output,
a result that it didn't deliver. Also, it helped by labeling JSC heap regions as reported by
vmmap tool, but at the same time, it made them mislabeled as malloc'd ones - the correct
way to label mapped regions is to use a VM tag.

So, it makes more sense to remove it completely than to make it work with multiple heaps.

• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/AllInOneFile.cpp:
• kjs/InitializeThreading.cpp: (KJS::initializeThreading):
• kjs/collector.cpp:
• kjs/collector.h:
• kjs/CollectorHeapIntrospector.cpp: Removed.
• kjs/CollectorHeapIntrospector.h: Removed.

File:

• trunk/JavaScriptCore/kjs/InitializeThreading.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/InitializeThreading.cpp

@@ -59 +59 @@
 #if PLATFORM(DARWIN) && USE(MULTIPLE_THREADS)
     pthread_once(&initializeThreadingKeyOnce, initializeThreadingOnce);
-
-    // FIXME: do we want heap introspector to work on other threads?
-    if (pthread_main_np())
-       JSGlobalData::threadInstance().heap->initializeHeapIntrospector();
 #else
     static bool initializedThreading = false;