Changeset 35177 in webkit for trunk/JavaScriptCore/kjs/ustring.cpp

Timestamp:

Jul 14, 2008, 7:17:56 PM (17 years ago)

Author:

[email protected]

Message:

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20037
Bug 20037: GCC 4.2 build broken due to strict aliasing violation.

Reviewed by Sam Weinig.

• kjs/ustring.cpp:

(KJS::UString::Rep::computeHash): Add a version of computeHash that takes a char* and explicit length.

• kjs/ustring.h:
• profiler/CallIdentifier.h:

(WTF::): Use new version of computeHash that takes a char* and explicit length to avoid unsafe aliasing.

File:

• trunk/JavaScriptCore/kjs/ustring.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/ustring.cpp

@@ -314 +314 @@
 // Paul Hsieh's SuperFastHash
 // http://www.azillionmonkeys.com/qed/hash.html
-unsigned UString::Rep::computeHash(const char* s)
+unsigned UString::Rep::computeHash(const char* s, int l)
 {
     // This hash is designed to work on 16-bit chunks at a time. But since the normal case
@@ -322 +322 @@
     uint32_t hash = PHI;
     uint32_t tmp;
-    size_t l = strlen(s);
 
     size_t rem = l & 1;