Changeset 35195 in webkit for trunk/JavaScriptCore/kjs/lookup.cpp

Timestamp:

Jul 16, 2008, 1:07:11 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Geoff.

Dereference identifiers when deleting a hash table (fixes leaks with private JSGlobalData
objects).

• kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData):
• kjs/lookup.cpp: (KJS::HashTable::deleteTable):
• kjs/lookup.h:
• kjs/lexer.cpp: (KJS::Lexer::~Lexer) HashTable cannot have a destructor, because check-for-global-initializers complains about having a global constructor then.

File:

• trunk/JavaScriptCore/kjs/lookup.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/lookup.cpp

@@ -43 +43 @@
 }
 
+void HashTable::deleteTable() const
+{
+    if (table) {
+        for (int i = 0; i != hashSizeMask + 1; ++i) {
+            if (UString::Rep* key = table[i].key)
+                key->deref();
+        }
+        delete[] table;
+        table = 0;
+    }
+}
+
 JSValue* staticFunctionGetter(ExecState* exec, const Identifier& propertyName, const PropertySlot& slot)
 {