Changeset 35245 in webkit for trunk/JavaScriptCore/kjs/Error.cpp

Timestamp:

Jul 18, 2008, 6:44:24 PM (17 years ago)

Author:

[email protected]

Message:

Bug 18774: SQUIRRELFISH: print meaningful error messages <​https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Cameron Zwarich

Add support for decent error messages in JavaScript. This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception. In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.

File:

• trunk/JavaScriptCore/kjs/Error.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/Error.cpp

@@ -33 +33 @@
 
 namespace KJS {
+
+const char* expressionBeginOffsetPropertyName = "expressionBeginOffset";
+const char* expressionCaretOffsetPropertyName = "expressionCaretOffset";
+const char* expressionEndOffsetPropertyName = "expressionEndOffset";
 
 JSObject* Error::create(ExecState* exec, ErrorType type, const UString& message, int lineNumber, int sourceId, const UString& sourceURL)
@@ -79 +83 @@
 
     if (lineNumber != -1)
-        error->put(exec, Identifier(exec, "line"), jsNumber(exec, lineNumber));
+        error->putWithAttributes(exec, Identifier(exec, "line"), jsNumber(exec, lineNumber), ReadOnly | DontDelete);
     if (sourceId != -1)
-        error->put(exec, Identifier(exec, "sourceId"), jsNumber(exec, sourceId));
+        error->putWithAttributes(exec, Identifier(exec, "sourceId"), jsNumber(exec, sourceId), ReadOnly | DontDelete);
     if (!sourceURL.isNull())
-        error->put(exec, Identifier(exec, "sourceURL"), jsString(exec, sourceURL));
+        error->putWithAttributes(exec, Identifier(exec, "sourceURL"), jsString(exec, sourceURL), ReadOnly | DontDelete);
 
     return error;