Changeset 35291 in webkit for trunk/JavaScriptCore/kjs/JSGlobalObjectFunctions.cpp

Timestamp:

Jul 22, 2008, 10:10:05 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

This means a few things:

1. Register::jsValue() clients, including ArgList clients, must now supply an ExecState* when accessing an entry in an ArgList, in case the entry will need to create a JSValue* on the fly.

2. Register clients that definitely don't want to create a JSValue* on the fly now use different APIs: getJSValue() for clients that know the register contains a JSValue*, and v() for clients who just want a void*.

3. I had to change some headers around in order to resolve dependency problems created by using a Register in the ArgList header.

SunSpider reports no change.

JavaScriptGlue:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

WebCore:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

File:

• trunk/JavaScriptCore/kjs/JSGlobalObjectFunctions.cpp (modified) (7 diffs)

trunk/JavaScriptCore/kjs/JSGlobalObjectFunctions.cpp

@@ -51 +51 @@
 static JSValue* encode(ExecState* exec, const ArgList& args, const char* doNotEscape)
 {
-    UString str = args[0]->toString(exec);
+    UString str = args.at(exec, 0)->toString(exec);
     CString cstr = str.UTF8String(true);
     if (!cstr.c_str())
@@ -74 +74 @@
 {
     UString result = "";
-    UString str = args[0]->toString(exec);
+    UString str = args.at(exec, 0)->toString(exec);
     int k = 0;
     int len = str.size();
@@ -275 +275 @@
         return throwError(exec, EvalError, "The \"this\" value passed to eval must be the global object from which eval originated");
 
-    JSValue* x = args[0];
+    JSValue* x = args.at(exec, 0);
     if (!x->isString())
         return x;
@@ -295 +295 @@
 JSValue* globalFuncParseInt(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, parseInt(args[0]->toString(exec), args[1]->toInt32(exec)));
+    return jsNumber(exec, parseInt(args.at(exec, 0)->toString(exec), args.at(exec, 1)->toInt32(exec)));
 }
 
 JSValue* globalFuncParseFloat(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, parseFloat(args[0]->toString(exec)));
+    return jsNumber(exec, parseFloat(args.at(exec, 0)->toString(exec)));
 }
 
 JSValue* globalFuncIsNaN(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsBoolean(isnan(args[0]->toNumber(exec)));
+    return jsBoolean(isnan(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* globalFuncIsFinite(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double n = args[0]->toNumber(exec);
+    double n = args.at(exec, 0)->toNumber(exec);
     return jsBoolean(!isnan(n) && !isinf(n));
 }
@@ -359 +359 @@
     UString result = "";
     UString s;
-    UString str = args[0]->toString(exec);
+    UString str = args.at(exec, 0)->toString(exec);
     const UChar* c = str.data();
     for (int k = 0; k < str.size(); k++, c++) {
@@ -383 +383 @@
 {
     UString result = "";
-    UString str = args[0]->toString(exec);
+    UString str = args.at(exec, 0)->toString(exec);
     int k = 0;
     int len = str.size();
@@ -411 +411 @@
 {
     CStringBuffer string;
-    args[0]->toString(exec).getCString(string);
+    args.at(exec, 0)->toString(exec).getCString(string);
     puts(string.data());
     return jsUndefined();