Changeset 35291 in webkit for trunk/JavaScriptCore/kjs/MathObject.cpp

Timestamp:

Jul 22, 2008, 10:10:05 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

This means a few things:

1. Register::jsValue() clients, including ArgList clients, must now supply an ExecState* when accessing an entry in an ArgList, in case the entry will need to create a JSValue* on the fly.

2. Register clients that definitely don't want to create a JSValue* on the fly now use different APIs: getJSValue() for clients that know the register contains a JSValue*, and v() for clients who just want a void*.

3. I had to change some headers around in order to resolve dependency problems created by using a Register in the ArgList header.

SunSpider reports no change.

JavaScriptGlue:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

WebCore:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

File:

• trunk/JavaScriptCore/kjs/MathObject.cpp (modified) (9 diffs)

trunk/JavaScriptCore/kjs/MathObject.cpp

@@ -131 +131 @@
 JSValue* mathProtoFuncAbs(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double arg = args[0]->toNumber(exec);
+    double arg = args.at(exec, 0)->toNumber(exec);
     return signbit(arg) ? jsNumber(exec, -arg) : jsNumber(exec, arg);
 }
@@ -137 +137 @@
 JSValue* mathProtoFuncACos(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, acos(args[0]->toNumber(exec)));
+    return jsNumber(exec, acos(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncASin(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, asin(args[0]->toNumber(exec)));
+    return jsNumber(exec, asin(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncATan(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, atan(args[0]->toNumber(exec)));
+    return jsNumber(exec, atan(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncATan2(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, atan2(args[0]->toNumber(exec), args[1]->toNumber(exec)));
+    return jsNumber(exec, atan2(args.at(exec, 0)->toNumber(exec), args.at(exec, 1)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncCeil(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double arg = args[0]->toNumber(exec);
+    double arg = args.at(exec, 0)->toNumber(exec);
     if (signbit(arg) && arg > -1.0)
         return jsNumber(exec, -0.0);
@@ -165 +165 @@
 JSValue* mathProtoFuncCos(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, cos(args[0]->toNumber(exec)));
+    return jsNumber(exec, cos(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncExp(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, exp(args[0]->toNumber(exec)));
+    return jsNumber(exec, exp(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncFloor(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double arg = args[0]->toNumber(exec);
+    double arg = args.at(exec, 0)->toNumber(exec);
     if (signbit(arg) && arg == 0.0)
         return jsNumber(exec, -0.0);
@@ -183 +183 @@
 JSValue* mathProtoFuncLog(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, log(args[0]->toNumber(exec)));
+    return jsNumber(exec, log(args.at(exec, 0)->toNumber(exec)));
 }
 
@@ -191 +191 @@
     double result = -Inf;
     for (unsigned k = 0; k < argsCount; ++k) {
-        double val = args[k]->toNumber(exec);
+        double val = args.at(exec, k)->toNumber(exec);
         if (isnan(val)) {
             result = NaN;
@@ -207 +207 @@
     double result = +Inf;
     for (unsigned k = 0; k < argsCount; ++k) {
-        double val = args[k]->toNumber(exec);
+        double val = args.at(exec, k)->toNumber(exec);
         if (isnan(val)) {
             result = NaN;
@@ -222 +222 @@
     // ECMA 15.8.2.1.13
 
-    double arg = args[0]->toNumber(exec);
-    double arg2 = args[1]->toNumber(exec);
+    double arg = args.at(exec, 0)->toNumber(exec);
+    double arg2 = args.at(exec, 1)->toNumber(exec);
 
     if (isnan(arg2))
@@ -247 +247 @@
 JSValue* mathProtoFuncRound(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double arg = args[0]->toNumber(exec);
+    double arg = args.at(exec, 0)->toNumber(exec);
     if (signbit(arg) && arg >= -0.5)
          return jsNumber(exec, -0.0);
@@ -255 +255 @@
 JSValue* mathProtoFuncSin(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, sin(args[0]->toNumber(exec)));
+    return jsNumber(exec, sin(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncSqrt(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, sqrt(args[0]->toNumber(exec)));
+    return jsNumber(exec, sqrt(args.at(exec, 0)->toNumber(exec)));
 }
 
 JSValue* mathProtoFuncTan(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    return jsNumber(exec, tan(args[0]->toNumber(exec)));
+    return jsNumber(exec, tan(args.at(exec, 0)->toNumber(exec)));
 }