Changeset 35291 in webkit for trunk/JavaScriptCore/kjs/StringConstructor.cpp

Timestamp:

Jul 22, 2008, 10:10:05 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

This means a few things:

1. Register::jsValue() clients, including ArgList clients, must now supply an ExecState* when accessing an entry in an ArgList, in case the entry will need to create a JSValue* on the fly.

2. Register clients that definitely don't want to create a JSValue* on the fly now use different APIs: getJSValue() for clients that know the register contains a JSValue*, and v() for clients who just want a void*.

3. I had to change some headers around in order to resolve dependency problems created by using a Register in the ArgList header.

SunSpider reports no change.

JavaScriptGlue:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

WebCore:

2008-07-22 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

File:

• trunk/JavaScriptCore/kjs/StringConstructor.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/StringConstructor.cpp

@@ -37 +37 @@
         ArgList::const_iterator end = args.end();
         for (ArgList::const_iterator it = args.begin(); it != end; ++it)
-            *p++ = static_cast<UChar>((*it).toUInt32(exec));
+            *p++ = static_cast<UChar>((*it).jsValue(exec)->toUInt32(exec));
         s = UString(buf, args.size(), false);
     } else
@@ -64 +64 @@
     if (args.isEmpty())
         return new (exec) StringObject(exec, prototype);
-    return new (exec) StringObject(exec, prototype, args[0]->toString(exec));
+    return new (exec) StringObject(exec, prototype, args.at(exec, 0)->toString(exec));
 }
 
@@ -78 +78 @@
     if (args.isEmpty())
         return jsString(exec, "");
-    return jsString(exec, args[0]->toString(exec));
+    return jsString(exec, args.at(exec, 0)->toString(exec));
 }