Changeset 35418 in webkit for trunk/JavaScriptCore/API/JSClassRef.cpp

Timestamp:

Jul 29, 2008, 1:16:17 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Oliver Hunt.

Store UString::Rep::isStatic bit in identifierTable pointer instead of reportedCost for
slightly nicer code and a 0.5% SunSpider improvement.

File:

• trunk/JavaScriptCore/API/JSClassRef.cpp (modified) (4 diffs)

trunk/JavaScriptCore/API/JSClassRef.cpp

@@ -84 +84 @@
 OpaqueJSClass::~OpaqueJSClass()
 {
-    ASSERT(!m_className.rep()->identifierTable);
+    ASSERT(!m_className.rep()->identifierTable());
 
     if (m_staticValues) {
         OpaqueJSClassStaticValuesTable::const_iterator end = m_staticValues->end();
         for (OpaqueJSClassStaticValuesTable::const_iterator it = m_staticValues->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable);
+            ASSERT(!it->first->identifierTable());
             delete it->second;
         }
@@ -98 +98 @@
         OpaqueJSClassStaticFunctionsTable::const_iterator end = m_staticFunctions->end();
         for (OpaqueJSClassStaticFunctionsTable::const_iterator it = m_staticFunctions->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable);
+            ASSERT(!it->first->identifierTable());
             delete it->second;
         }
@@ -150 +150 @@
         OpaqueJSClassStaticValuesTable::const_iterator end = jsClass->m_staticValues->end();
         for (OpaqueJSClassStaticValuesTable::const_iterator it = jsClass->m_staticValues->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable);
+            ASSERT(!it->first->identifierTable());
             staticValues->add(UString::Rep::createCopying(it->first->data(), it->first->size()),
                               new StaticValueEntry(it->second->getProperty, it->second->setProperty, it->second->attributes));
@@ -163 +163 @@
         OpaqueJSClassStaticFunctionsTable::const_iterator end = jsClass->m_staticFunctions->end();
         for (OpaqueJSClassStaticFunctionsTable::const_iterator it = jsClass->m_staticFunctions->begin(); it != end; ++it) {
-            ASSERT(!it->first->identifierTable);
+            ASSERT(!it->first->identifierTable());
             staticFunctions->add(UString::Rep::createCopying(it->first->data(), it->first->size()),
                               new StaticFunctionEntry(it->second->callAsFunction, it->second->attributes));