Changeset 35533 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.cpp

Timestamp:

Aug 3, 2008, 2:58:21 AM (17 years ago)

Author:

[email protected]

Message:

Bug 19359: JavaScriptCore behaves differently from FF2/3 and IE when handling context in catch statement
<​https://bugs.webkit.org/show_bug.cgi?id=19359>

Reviewed by Cameron Zwarich

Make our catch behave like Firefox and IE, we do this by using a StaticScopeObject
instead of a generic JSObject for the scope node. We still don't make use of the
fact that we have a static scope inside the catch block, so the internal performance
of the catch block is not improved, even though technically it would be possible to
do so.

File:

• trunk/JavaScriptCore/VM/CodeGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -1151 +1151 @@
 }
 
+void CodeGenerator::emitPushNewScope(RegisterID* dst, Identifier& property, RegisterID* value)
+{
+    m_codeBlock->needsFullScopeChain = true;
+    ControlFlowContext context;
+    context.isFinallyBlock = false;
+    m_scopeContextStack.append(context);
+    m_dynamicScopeDepth++;
+    
+    emitOpcode(op_push_new_scope);
+    instructions().append(dst->index());
+    instructions().append(addConstant(property));
+    instructions().append(value->index());
+}
+
 void CodeGenerator::beginSwitch(RegisterID* scrutineeRegister, SwitchInfo::SwitchType type)
 {