Changeset 35593 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.h

Timestamp:

Aug 6, 2008, 3:37:34 AM (17 years ago)

Author:

[email protected]

Message:

2008-08-06 Cameron Zwarich <​[email protected]>

Reviewed by Maciej.

Bug 20286: Load constants all at once instead of using op_load
<​https://bugs.webkit.org/show_bug.cgi?id=20286>

Load constants all at once into temporary registers instead of using
individual instances of op_load.

This is a 2.6% speedup on SunSpider.

JavaScriptCore:

• JavaScriptCore.exp:
• VM/CodeBlock.cpp: (KJS::CodeBlock::dump): (KJS::CodeBlock::mark):
• VM/CodeBlock.h:
• VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::newTemporary): (KJS::CodeGenerator::addConstant): (KJS::CodeGenerator::addUnexpectedConstant): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitUnexpectedLoad): (KJS::CodeGenerator::emitNewError):
• VM/CodeGenerator.h:
• VM/Machine.cpp: (KJS::slideRegisterWindowForCall): (KJS::Machine::unwindCallFrame): (KJS::Machine::throwException): (KJS::Machine::execute): (KJS::Machine::privateExecute):
• VM/Machine.h:
• VM/Opcode.h:
• VM/RegisterID.h: (KJS::RegisterID::RegisterID): (KJS::RegisterID::makeConstant): (KJS::RegisterID::isTemporary):
• kjs/NodeInfo.h:
• kjs/Parser.cpp: (KJS::Parser::didFinishParsing):
• kjs/Parser.h: (KJS::Parser::parse):
• kjs/grammar.y:
• kjs/nodes.cpp: (KJS::NullNode::emitCode): (KJS::BooleanNode::emitCode): (KJS::NumberNode::emitCode): (KJS::StringNode::emitCode): (KJS::ArrayNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteValueNode::emitCode): (KJS::VoidNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ReturnNode::emitCode): (KJS::ScopeNode::ScopeNode): (KJS::ProgramNode::ProgramNode): (KJS::ProgramNode::create): (KJS::EvalNode::EvalNode): (KJS::EvalNode::create): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::create): (KJS::FunctionBodyNode::emitCode):
• kjs/nodes.h: (KJS::ScopeNode::neededConstants):

LayoutTests:

• fast/js/constant-count-expected.txt: Added.
• fast/js/constant-count.html: Added.
• fast/js/deep-recursion-test.html:
• fast/js/resources/constant-count.js: Added.

File:

• trunk/JavaScriptCore/VM/CodeGenerator.h (modified) (3 diffs)

trunk/JavaScriptCore/VM/CodeGenerator.h

@@ -231 +231 @@
         RegisterID* emitLoad(RegisterID* dst, double);
         RegisterID* emitLoad(RegisterID* dst, JSValue*);
+        RegisterID* emitUnexpectedLoad(RegisterID* dst, bool);
 
         RegisterID* emitNullaryOp(OpcodeID, RegisterID* dst);
@@ -376 +377 @@
         unsigned addConstant(FuncExprNode*);
         unsigned addConstant(const Identifier&);
-        unsigned addConstant(JSValue*);
+        RegisterID* addConstant(JSValue*);
+        unsigned addUnexpectedConstant(JSValue*);
         unsigned addRegExp(RegExp* r);
 
@@ -397 +399 @@
         RegisterID m_thisRegister;
         SegmentedVector<RegisterID, 512> m_locals;
+        SegmentedVector<RegisterID, 512> m_constants;
         SegmentedVector<RegisterID, 512> m_temporaries;
         SegmentedVector<LabelID, 512> m_labels;