Changeset 35652 in webkit for trunk/JavaScriptCore/VM/CodeBlock.cpp

Timestamp:

Aug 9, 2008, 4:00:38 AM (17 years ago)

Author:

[email protected]

Message:

2008-08-09 Cameron Zwarich <​[email protected]>

Reviewed by Oliver.

Revision 35651, despite being a rather trivial change, introduced a
large regression on the regexp-dna SunSpider test. This regression
stemmed from an increase in the size of CodeBlock::dump(). There is
no reason for this method (and several related methods) to be compiled
in non-debug builds with the sampling tool disabled. This patch
conditionally compiles them, reversing the regression on SunSpider.

• JavaScriptCore.exp:
• VM/CodeBlock.cpp:
• VM/CodeBlock.h:
• VM/Machine.cpp:

File:

• trunk/JavaScriptCore/VM/CodeBlock.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CodeBlock.cpp

@@ -38 +38 @@
 namespace KJS {
 
+#if !defined(NDEBUG) || ENABLE_SAMPLING_TOOL
+
 static UString escapeQuotes(const UString& str)
 {
@@ -703 +705 @@
 }
 
+#endif // !defined(NDEBUG) || ENABLE_SAMPLING_TOOL
+
 void CodeBlock::mark()
 {