Changeset 35652 in webkit for trunk/JavaScriptCore/VM/Machine.cpp

Timestamp:

Aug 9, 2008, 4:00:38 AM (17 years ago)

Author:

[email protected]

Message:

2008-08-09 Cameron Zwarich <​[email protected]>

Reviewed by Oliver.

Revision 35651, despite being a rather trivial change, introduced a
large regression on the regexp-dna SunSpider test. This regression
stemmed from an increase in the size of CodeBlock::dump(). There is
no reason for this method (and several related methods) to be compiled
in non-debug builds with the sampling tool disabled. This patch
conditionally compiles them, reversing the regression on SunSpider.

• JavaScriptCore.exp:
• VM/CodeBlock.cpp:
• VM/CodeBlock.h:
• VM/Machine.cpp:

File:

• trunk/JavaScriptCore/VM/Machine.cpp (modified) (3 diffs)

trunk/JavaScriptCore/VM/Machine.cpp

@@ -550 +550 @@
 }
 
+#ifndef NDEBUG
+
 void Machine::dumpCallFrame(const CodeBlock* codeBlock, ScopeChainNode* scopeChain, RegisterFile* registerFile, const Register* r)
 {
@@ -621 +623 @@
 }
 
+#endif
+
+#if !defined(NDEBUG) || HAVE(SAMPLING_TOOL)
+
 bool Machine::isOpcode(Opcode opcode)
 {
@@ -631 +637 @@
 #endif
 }
+
+#endif
 
 NEVER_INLINE bool Machine::unwindCallFrame(ExecState* exec, JSValue* exceptionValue, const Instruction*& vPC, CodeBlock*& codeBlock, ScopeChainNode*& scopeChain, Register*& r)