Changeset 35756 in webkit for trunk/JavaScriptCore/profiler/ProfileGenerator.cpp

Timestamp:

Aug 14, 2008, 11:11:20 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-08-14 Kevin McCullough <​[email protected]>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

• Profiles now have a unique ID so that they can be linked to the console message that announces that a profile completed.

• profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile):
• profiler/Profile.cpp: (KJS::Profile::create): (KJS::Profile::Profile):
• profiler/Profile.h: (KJS::Profile::uid):
• profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
• profiler/ProfileGenerator.h:
• profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
• profiler/TreeProfile.cpp: (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
• profiler/TreeProfile.h:

WebCore:

2008-08-14 Kevin McCullough <​[email protected]>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

• page/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): Called by addProfile this is the function that adds a message to the console that a profile finished.
• page/InspectorController.h:
• page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match the console log to the profile in the web inspector. (WebCore::getUniqueIdCallback): (WebCore::ProfileClass):
• page/inspector/ProfilesPanel.js: Created a map of all the profiles by Id to bring up the requested profile. Also select and reveal the profile in the profile panel. And created displayTitleForProfileLink() which formats a title taking into account if it's user initiated or if there are multiples. Lasty, I put the user initiated profile in a variable.
• page/inspector/inspector.js: Make the profile title be a clickable link that will take the user to the identified profile. Also expose the count of user initiated profiles so they can be displayed in the console with the correct count.

File:

• trunk/JavaScriptCore/profiler/ProfileGenerator.cpp (modified) (2 diffs)

trunk/JavaScriptCore/profiler/ProfileGenerator.cpp

@@ -34 +34 @@
 static const char* NonJSExecution = "(idle)";
 
-PassRefPtr<ProfileGenerator> ProfileGenerator::create(const UString& title, ExecState* originatingGlobalExec, unsigned profileGroup, ProfilerClient* client)
+PassRefPtr<ProfileGenerator> ProfileGenerator::create(const UString& title, ExecState* originatingGlobalExec, unsigned profileGroup, ProfilerClient* client, unsigned uid)
 {
-    return adoptRef(new ProfileGenerator(title, originatingGlobalExec, profileGroup, client));
+    return adoptRef(new ProfileGenerator(title, originatingGlobalExec, profileGroup, client, uid));
 }
 
-ProfileGenerator::ProfileGenerator(const UString& title, ExecState* originatingGlobalExec, unsigned profileGroup, ProfilerClient* client)
+ProfileGenerator::ProfileGenerator(const UString& title, ExecState* originatingGlobalExec, unsigned profileGroup, ProfilerClient* client, unsigned uid)
     : m_originatingGlobalExec(originatingGlobalExec)
     , m_profileGroup(profileGroup)
@@ -46 +46 @@
     , m_stoppedCallDepth(0)
 {
-    m_profile = Profile::create(title);
+    m_profile = Profile::create(title, uid);
     m_currentNode = m_head = m_profile->head();
 }