Changeset 35775 in webkit for trunk/JavaScriptCore/API/APICast.h

Timestamp:

Aug 15, 2008, 12:43:48 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Geoff Garen.

JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.

Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.

File:

• trunk/JavaScriptCore/API/APICast.h (modified) (3 diffs)

trunk/JavaScriptCore/API/APICast.h

@@ -41 +41 @@
 typedef const struct OpaqueJSContext* JSContextRef;
 typedef struct OpaqueJSContext* JSGlobalContextRef;
-typedef struct OpaqueJSString* JSStringRef;
 typedef struct OpaqueJSPropertyNameAccumulator* JSPropertyNameAccumulatorRef;
 typedef const struct OpaqueJSValue* JSValueRef;
@@ -61 +60 @@
 {
     return reinterpret_cast<KJS::JSValue*>(const_cast<OpaqueJSValue*>(v));
-}
-
-inline KJS::UString::Rep* toJS(JSStringRef b)
-{
-    return reinterpret_cast<KJS::UString::Rep*>(b);
 }
 
@@ -91 +85 @@
 {
     return reinterpret_cast<JSValueRef*>(const_cast<const KJS::JSValue**>(v));
-}
-
-inline JSStringRef toRef(KJS::UString::Rep* s)
-{
-    return reinterpret_cast<JSStringRef>(s);
 }