Changeset 35810 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.cpp

Timestamp:

Aug 17, 2008, 2:27:56 PM (17 years ago)

Author:

[email protected]

Message:

2008-08-17 Cameron Zwarich <​[email protected]>

Reviewed by Maciej.

Bug 20419: Remove op_jless
<​https://bugs.webkit.org/show_bug.cgi?id=20419>

Remove op_jless, which is rarely used now that we have op_loop_if_less.

• VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
• VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue):
• VM/Machine.cpp: (KJS::Machine::privateExecute):
• VM/Opcode.h:

File:

• trunk/JavaScriptCore/VM/CodeGenerator.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CodeGenerator.cpp

@@ -463 +463 @@
 PassRefPtr<LabelID> CodeGenerator::emitJumpIfTrue(RegisterID* cond, LabelID* target)
 {
-    if (m_lastOpcodeID == op_less) {
+    if (m_lastOpcodeID == op_less && !target->isForwardLabel()) {
         int dstIndex;
         int src1Index;
@@ -472 +472 @@
         if (cond->index() == dstIndex && cond->isTemporary() && !cond->refCount()) {
             rewindBinaryOp();
-            emitOpcode(target->isForwardLabel() ? op_jless : op_loop_if_less);
+            emitOpcode(op_loop_if_less);
             instructions().append(src1Index);
             instructions().append(src2Index);