Changeset 36068 in webkit for trunk/JavaScriptCore/profiler/ProfileGenerator.cpp

Timestamp:

Sep 3, 2008, 2:53:17 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-09-03 Kevin McCullough <​[email protected]>

Reviewed by Tim.

Remove the rest of the "zombie" code from the profiler.

• There is no longer a need for the ProfilerClient callback mechanism.

• API/JSProfilerPrivate.cpp: (JSStartProfiling):
• JavaScriptCore.exp:
• profiler/HeavyProfile.h:
• profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
• profiler/ProfileGenerator.h: (KJS::ProfileGenerator::profileGroup):
• profiler/Profiler.cpp: (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): Immediately return the profile when stopped instead of using a callback.
• profiler/Profiler.h:
• profiler/TreeProfile.h:

WebCore:

2008-09-03 Kevin McCullough <​[email protected]>

Reviewed by Tim.

Remove the rest of the "zombie" code from the profiler.

• There is no longer a need for the ProfilerClient callback mechanism.

• page/Console.cpp: (WebCore::Console::Console): (WebCore::Console::profile): (WebCore::Console::profileEnd): Move the variables from the header to here since we don't have to wait for a callback to use them.
• page/Console.h:
• page/InspectorController.cpp: (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
• page/InspectorController.h:

File:

• trunk/JavaScriptCore/profiler/ProfileGenerator.cpp (modified) (1 diff)

trunk/JavaScriptCore/profiler/ProfileGenerator.cpp

@@ -40 +40 @@
 static const char* NonJSExecution = "(idle)";
 
-PassRefPtr<ProfileGenerator> ProfileGenerator::create(const UString& title, ExecState* originatingExec, ProfilerClient* client, unsigned uid)
+PassRefPtr<ProfileGenerator> ProfileGenerator::create(const UString& title, ExecState* originatingExec, unsigned uid)
 {
-    return adoptRef(new ProfileGenerator(title, originatingExec, client, uid));
+    return adoptRef(new ProfileGenerator(title, originatingExec, uid));
 }
 
-ProfileGenerator::ProfileGenerator(const UString& title, ExecState* originatingExec, ProfilerClient* client, unsigned uid)
+ProfileGenerator::ProfileGenerator(const UString& title, ExecState* originatingExec, unsigned uid)
     : m_originatingGlobalExec(originatingExec->lexicalGlobalObject()->globalExec())
     , m_profileGroup(originatingExec->lexicalGlobalObject()->profileGroup())
-    , m_client(client)
+
 {
     m_profile = Profile::create(title, uid);