Changeset 36304 in webkit for trunk/JavaScriptCore/kjs/JSObject.h

Timestamp:

Sep 9, 2008, 4:42:47 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-09 Sam Weinig <​[email protected]>

Reviewed by Geoffrey Garen.

Replace uses of PropertyMap::get and PropertyMap::getLocation with
PropertyMap::getOffset.

Sunspider reports this as a .6% improvement.

• JavaScriptCore.exp:
• kjs/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::getPropertyAttributes):
• kjs/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::locationForOffset):
• kjs/PropertyMap.cpp: (JSC::PropertyMap::remove): (JSC::PropertyMap::getOffset):
• kjs/PropertyMap.h:

File:

• trunk/JavaScriptCore/kjs/JSObject.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSObject.h

@@ -125 +125 @@
         JSValue* getDirect(const Identifier& propertyName) const
         {
-            return m_structureID->propertyMap().get(propertyName, m_propertyStorage);
+            size_t offset = m_structureID->propertyMap().getOffset(propertyName);
+            return offset != WTF::notFound ? m_propertyStorage[offset] : 0;
         }
 
         JSValue** getDirectLocation(const Identifier& propertyName)
         {
-            return m_structureID->propertyMap().getLocation(propertyName, m_propertyStorage);
+            size_t offset = m_structureID->propertyMap().getOffset(propertyName);
+            return offset != WTF::notFound ? locationForOffset(offset) : 0;
         }
 
         JSValue** getDirectLocation(const Identifier& propertyName, bool& isWriteable)
         {
-            return m_structureID->propertyMap().getLocation(propertyName, isWriteable, m_propertyStorage);
+            size_t offset = m_structureID->propertyMap().getOffset(propertyName, isWriteable);
+            return offset != WTF::notFound ? locationForOffset(offset) : 0;
         }
 
@@ -141 +144 @@
         {
             return location - m_propertyStorage.get();
+        }
+
+        JSValue** locationForOffset(size_t offset)
+        {
+            return &m_propertyStorage[offset];
         }