Changeset 36317 in webkit for trunk/JavaScriptCore/VM/CodeGenerator.h

Timestamp:

Sep 10, 2008, 2:23:35 AM (17 years ago)

Author:

[email protected]

Message:

Add optimised access to known properties on the global object.

Reviewed by Maciej Stachowiak

Improve cross scope access to the global object by emitting
code to access it directly rather than by walking the scope chain.

This is a 0.8% win in SunSpider and a 1.7% win in the v8 benchmarks.

File:

• trunk/JavaScriptCore/VM/CodeGenerator.h (modified) (2 diffs)

trunk/JavaScriptCore/VM/CodeGenerator.h

@@ -104 +104 @@
         // NB: depth does _not_ include the local scope.  eg. a depth of 0 refers
         // to the scope containing this codeblock.
-        bool findScopedProperty(const Identifier&, int& index, size_t& depth, bool forWriting);
+        bool findScopedProperty(const Identifier&, int& index, size_t& depth, bool forWriting, JSValue*& globalObject);
 
         // Returns the register storing "this"
@@ -257 +257 @@
 
         RegisterID* emitResolve(RegisterID* dst, const Identifier& property);
-        RegisterID* emitGetScopedVar(RegisterID* dst, size_t skip, int index);
-        RegisterID* emitPutScopedVar(size_t skip, int index, RegisterID* value);
+        RegisterID* emitGetScopedVar(RegisterID* dst, size_t skip, int index, JSValue* globalObject);
+        RegisterID* emitPutScopedVar(size_t skip, int index, RegisterID* value, JSValue* globalObject);
 
         RegisterID* emitResolveBase(RegisterID* dst, const Identifier& property);