Changeset 36412 in webkit for trunk/JavaScriptCore/VM/CodeBlock.cpp

Timestamp:

Sep 14, 2008, 5:26:08 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Cameron Zwarich <​[email protected]>

Reviewed by Maciej Stachowiak.

Bug 20827: the 'typeof' operator is slow
<​https://bugs.webkit.org/show_bug.cgi?id=20827>

Optimize the 'typeof' operator when its result is compared to a constant
string.

This is a 5.5% speedup on the V8 Earley-Boyer test.

JavaScriptCore:

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
• VM/CodeGenerator.h:
• VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function):
• VM/Machine.h:
• VM/Opcode.h:
• kjs/nodes.cpp: (JSC::BinaryOpNode::emitCode): (JSC::EqualNode::emitCode): (JSC::StrictEqualNode::emitCode):
• kjs/nodes.h:

LayoutTests:

• fast/js/resources/typeof-codegen-crash.js: Added.
• fast/js/typeof-codegen-crash-expected.txt: Added.
• fast/js/typeof-codegen-crash.html: Added.

File:

• trunk/JavaScriptCore/VM/CodeBlock.cpp (modified) (1 diff)

trunk/JavaScriptCore/VM/CodeBlock.cpp

@@ -496 +496 @@
             break;
         }
+        case op_is_undefined: {
+            printUnaryOp(location, it, "is_undefined");
+            break;
+        }
+        case op_is_boolean: {
+            printUnaryOp(location, it, "is_boolean");
+            break;
+        }
+        case op_is_number: {
+            printUnaryOp(location, it, "is_number");
+            break;
+        }
+        case op_is_string: {
+            printUnaryOp(location, it, "is_string");
+            break;
+        }
+        case op_is_object: {
+            printUnaryOp(location, it, "is_object");
+            break;
+        }
+        case op_is_function: {
+            printUnaryOp(location, it, "is_function");
+            break;
+        }
         case op_in: {
             printBinaryOp(location, it, "in");