Changeset 36418 in webkit for trunk/JavaScriptCore/VM/CodeBlock.cpp

Timestamp:

Sep 14, 2008, 7:18:13 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• split the "prototype" lookup for hasInstance into opcode stream so it can be cached

~5% speedup on v8 earley-boyer test

• API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
• API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
• API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
• JavaScriptCore.exp:
• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
• VM/CodeGenerator.h:
• VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
• kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
• kjs/JSObject.h:
• kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
• kjs/nodes.h:

File:

• trunk/JavaScriptCore/VM/CodeBlock.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CodeBlock.cpp

@@ -278 +278 @@
         size_t i = 0;
         do {
-             printStructureIDs(&instructions[structureIDInstructions[i]]);
+             printStructureIDs(&instructions[structureIDInstructions[i].opcodeIndex]);
              ++i;
         } while (i < structureIDInstructions.size());
@@ -876 +876 @@
 {
     size_t size = structureIDInstructions.size();
-    for (size_t i = 0; i < size; ++i)
-        derefStructureIDs(&instructions[structureIDInstructions[i]]);
-
-    size = structureIDAccessStubs.size();
-    for (size_t i = 0; i < size; ++i)
-        fastFree(structureIDAccessStubs[i]);
-
+    for (size_t i = 0; i < size; ++i) {
+        derefStructureIDs(&instructions[structureIDInstructions[i].opcodeIndex]);
+        if (structureIDInstructions[i].stubRoutine)
+            fastFree(structureIDInstructions[i].stubRoutine);
+    }
 #if ENABLE(CTI)
     if (ctiCode)