Changeset 36427 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Sep 14, 2008, 11:26:15 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-14 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up JS construction by extracting "prototype" lookup so PIC applies.

~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.

• VM/CTI.cpp: (JSC::CTI::compileOpCall): Account for extra arg for prototype. (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
• VM/Machine.cpp: (JSC::Machine::privateExecute): Expect prototype arg in op_construct. (JSC::Machine::cti_op_construct_JSConstruct): ditto (JSC::Machine::cti_op_construct_NotJSConstruct): ditto

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (3 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -413 +413 @@
 {
     if (type == OpConstruct) {
-        emitPutArgConstant(reinterpret_cast<unsigned>(instruction + i), 12);
+        emitPutArgConstant(reinterpret_cast<unsigned>(instruction + i), 16);
+        emitPutArgConstant(instruction[i + 5].u.operand, 12);
         emitPutArgConstant(instruction[i + 4].u.operand, 8);
-        emitPutArgConstant(instruction[i + 3].u.operand, 4);
+        emitGetPutArg(instruction[i + 3].u.operand, 4, X86::ecx);
     } else {
         emitPutArgConstant(reinterpret_cast<unsigned>(instruction + i), 16);
@@ -434 +435 @@
         m_jit.emitRestoreArgumentReference();
 
-       emitGetCTIParam(CTI_ARGS_r, X86::edi); // edi := r
+        emitGetCTIParam(CTI_ARGS_r, X86::edi); // edi := r
 
         m_jit.cmpl_i32r(reinterpret_cast<unsigned>(JSImmediate::impossibleValue()), X86::eax);
@@ -825 +826 @@
         case op_construct: {
             compileOpCall(instruction, i, OpConstruct);
-            i += 5;
+            i += 6;
             break;
         }