Changeset 36429 in webkit for trunk/JavaScriptCore/kjs/PropertyMap.cpp

Timestamp:

Sep 15, 2008, 12:27:14 AM (17 years ago)

Author:

[email protected]

Message:

2008-09-15 Sam Weinig <​[email protected]>

Reviewed by Maciej Stachowiak.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.

~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.

• kjs/JSObject.cpp: (JSC::JSObject::getPropertyNames):
• kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames):
• kjs/PropertyMap.h:
• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::getEnumerablePropertyNames):
• kjs/StructureID.h:

File:

• trunk/JavaScriptCore/kjs/PropertyMap.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/PropertyMap.cpp

@@ -24 +24 @@
 #include "JSObject.h"
 #include "protect.h"
-#include "PropertyNameArray.h"
 #include <algorithm>
 #include <wtf/Assertions.h>
@@ -474 +473 @@
 }
 
-void PropertyMap::getEnumerablePropertyNames(PropertyNameArray& propertyNames) const
+void PropertyMap::getEnumerablePropertyNames(Vector<UString::Rep*>& propertyNames) const
 {
     if (!m_table)
@@ -493 +492 @@
             }
         }
-        if (!propertyNames.size()) {
-            for (int k = 0; k < i; ++k)
-                propertyNames.addKnownUnique(a[k]->key);
-        } else {
-            for (int k = 0; k < i; ++k)
-                propertyNames.add(a[k]->key);
-        }
+        propertyNames.reserveCapacity(i);
+        for (int k = 0; k < i; ++k)
+            propertyNames.append(a[k]->key);
         return;
     }
@@ -518 +513 @@
 
     // Put the keys of the sorted entries into the list.
-    for (Entry** q = sortedEnumerables.data(); q != p; ++q)
-        propertyNames.add(q[0]->key);
+    propertyNames.reserveCapacity(sortedEnumerables.size());
+    for (size_t i = 0; i < sortedEnumerables.size(); ++i)
+        propertyNames.append(sortedEnumerables[i]->key);
 }