Changeset 36429 in webkit for trunk/JavaScriptCore/kjs/PropertyMap.h

Timestamp:

Sep 15, 2008, 12:27:14 AM (17 years ago)

Author:

[email protected]

Message:

2008-09-15 Sam Weinig <​[email protected]>

Reviewed by Maciej Stachowiak.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.

~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.

• kjs/JSObject.cpp: (JSC::JSObject::getPropertyNames):
• kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames):
• kjs/PropertyMap.h:
• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::getEnumerablePropertyNames):
• kjs/StructureID.h:

File:

• trunk/JavaScriptCore/kjs/PropertyMap.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/PropertyMap.h

@@ -31 +31 @@
     class JSObject;
     class JSValue;
-    class PropertyNameArray;
 
     typedef JSValue** PropertyStorage;
@@ -95 +94 @@
         size_t getOffset(const Identifier& propertyName, unsigned& attributes);
 
-        void getEnumerablePropertyNames(PropertyNameArray&) const;
+        void getEnumerablePropertyNames(Vector<UString::Rep*>&) const;
 
         bool hasGetterSetterProperties() const { return m_getterSetterFlag; }