Changeset 36429 in webkit for trunk/JavaScriptCore/kjs/StructureID.cpp

Timestamp:

Sep 15, 2008, 12:27:14 AM (17 years ago)

Author:

[email protected]

Message:

2008-09-15 Sam Weinig <​[email protected]>

Reviewed by Maciej Stachowiak.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.

~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.

• kjs/JSObject.cpp: (JSC::JSObject::getPropertyNames):
• kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames):
• kjs/PropertyMap.h:
• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::getEnumerablePropertyNames):
• kjs/StructureID.h:

File:

• trunk/JavaScriptCore/kjs/StructureID.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/StructureID.cpp

@@ -29 +29 @@
 #include "identifier.h"
 #include "JSObject.h"
+#include "PropertyNameArray.h";
 #include <wtf/RefPtr.h>
 
@@ -35 +36 @@
 namespace JSC {
 
-    StructureID::StructureID(JSValue* prototype, JSType type)
+StructureID::StructureID(JSValue* prototype, JSType type)
     : m_isDictionary(false)
     , m_type(type)
@@ -46 +47 @@
     ASSERT(m_prototype);
     ASSERT(m_prototype->isObject() || m_prototype->isNull());
+}
+
+void StructureID::getEnumerablePropertyNames(PropertyNameArray& propertyNames) const
+{
+    if (m_cachedPropertyNameArray.isEmpty())
+        m_propertyMap.getEnumerablePropertyNames(m_cachedPropertyNameArray);
+
+    if (!propertyNames.size()) {
+        for (size_t i = 0; i < m_cachedPropertyNameArray.size(); ++i)
+            propertyNames.addKnownUnique(m_cachedPropertyNameArray[i]);
+    } else {
+        for (size_t i = 0; i < m_cachedPropertyNameArray.size(); ++i)
+            propertyNames.add(m_cachedPropertyNameArray[i]);
+    }
 }