Changeset 36429 in webkit for trunk/JavaScriptCore/kjs/StructureID.h

Timestamp:

Sep 15, 2008, 12:27:14 AM (17 years ago)

Author:

[email protected]

Message:

2008-09-15 Sam Weinig <​[email protected]>

Reviewed by Maciej Stachowiak.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.

~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.

• kjs/JSObject.cpp: (JSC::JSObject::getPropertyNames):
• kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames):
• kjs/PropertyMap.h:
• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::getEnumerablePropertyNames):
• kjs/StructureID.h:

File:

• trunk/JavaScriptCore/kjs/StructureID.h (modified) (3 diffs)

trunk/JavaScriptCore/kjs/StructureID.h

@@ -40 +40 @@
 
     class JSValue;
+    class PropertyNameArray;
     class StructureIDChain;
 
@@ -108 +109 @@
         PropertyMap& propertyMap() { return m_propertyMap; }
 
+        void getEnumerablePropertyNames(PropertyNameArray&) const;
+
         static void transitionTo(StructureID* oldStructureID, StructureID* newStructureID, JSObject* slotBase);
 
@@ -131 +134 @@
         TransitionTable m_transitionTable;
 
+        mutable Vector<UString::Rep*> m_cachedPropertyNameArray;
+
         PropertyMap m_propertyMap;
     };