Changeset 36631 in webkit for trunk/JavaScriptCore/JavaScriptCore.exp

Timestamp:

Sep 18, 2008, 4:30:23 PM (17 years ago)

Author:

Darin Adler

Message:

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=20925 LEAK messages appear every time I quit

• JavaScriptCore.exp: Updated, and also added an export needed for future WebCore use of JSC::StructureID.

• wtf/RefCountedLeakCounter.cpp: (WTF::RefCountedLeakCounter::suppressMessages): Added. (WTF::RefCountedLeakCounter::cancelMessageSuppression): Added. (WTF::RefCountedLeakCounter::RefCountedLeakCounter): Tweaked a bit. (WTF::RefCountedLeakCounter::~RefCountedLeakCounter): Added code to log the reason there was no leak checking done. (WTF::RefCountedLeakCounter::increment): Tweaked a bit. (WTF::RefCountedLeakCounter::decrement): Ditto.

• wtf/RefCountedLeakCounter.h: Replaced setLogLeakMessages with two new functions, suppressMessages and cancelMessageSuppression. Also added m_ prefixes to the data member names.

2008-09-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• fix ​https://bugs.webkit.org/show_bug.cgi?id=20925 LEAK messages appear every time I quit

• WebView/WebPreferences.mm: (-[WebPreferences setFullDocumentTeardownEnabled:]): Removed unneeded call to setLogLeakMessages.
• WebView/WebView.mm: (-[WebView _closeWithFastTeardown]): Call RefCountedLeakCounter::suppressMessages, telling it that we can't track leaks because at least one WebView was closed with fast teardown. (-[WebView _close]): Removed unneeded call to setLogLeakMessages. Added a call to cancelMessageSuppression since the WebView is no longer open. Added an explicit garbage collect to help with the case where we're closing during the quit process -- the garbageCollectSoon() calls done inside WebCore won't help us in that case. (-[WebView initWithFrame:frameName:groupName:]): Call RefCountedLeakCounter::suppressMessages telling it that we can't track leaks because at least one WebView is currently open.

File:

• trunk/JavaScriptCore/JavaScriptCore.exp (modified) (2 diffs)

trunk/JavaScriptCore/JavaScriptCore.exp

@@ -111 +111 @@
 __ZN3JSC11StructureID24fromDictionaryTransitionEPS0_
 __ZN3JSC11StructureID25changePrototypeTransitionEPS0_PNS_7JSValueE
+__ZN3JSC11StructureIDC1EPNS_7JSValueENS_6JSTypeE
 __ZN3JSC11StructureIDD1Ev
 __ZN3JSC12DateInstance4infoE
@@ -262 +263 @@
 __ZN3WTF16callOnMainThreadEPFvPvES0_
 __ZN3WTF16fastZeroedMallocEm
-__ZN3WTF18setLogLeakMessagesEb
 __ZN3WTF19initializeThreadingEv
+__ZN3WTF21RefCountedLeakCounter16suppressMessagesEPKc
+__ZN3WTF21RefCountedLeakCounter24cancelMessageSuppressionEPKc
 __ZN3WTF21RefCountedLeakCounter9decrementEv
 __ZN3WTF21RefCountedLeakCounter9incrementEv