Changeset 36727 in webkit for trunk/JavaScriptCore/VM/Machine.cpp

Timestamp:

Sep 20, 2008, 10:54:23 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-20 Maciej Stachowiak <​[email protected]>

Reviewed by Darin.

• assorted optimizations to === and !== operators (work towards <​https://bugs.webkit.org/show_bug.cgi?id=20820>)

2.5% speedup on earley-boyer test

• VM/Machine.cpp: (JSC::Machine::cti_op_stricteq): Use inline version of strictEqualSlowCase; remove unneeded exception check. (JSC::Machine::cti_op_nstricteq): ditto
• kjs/operations.cpp: (JSC::strictEqual): Use strictEqualSlowCaseInline (JSC::strictEqualSlowCase): ditto
• kjs/operations.h: (JSC::strictEqualSlowCaseInline): Version of strictEqualSlowCase that can be inlined, since the extra function call indirection is a lose for CTI.

File:

• trunk/JavaScriptCore/VM/Machine.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/Machine.cpp

@@ -5302 +5302 @@
     if (JSImmediate::areBothImmediate(src1, src2))
         return jsBoolean(reinterpret_cast<intptr_t>(src1) == reinterpret_cast<intptr_t>(src2));
-    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 != JSImmediate::from(0)) & (src2 != JSImmediate::from(0)))
+    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 != JSImmediate::zeroImmediate()) & (src2 != JSImmediate::zeroImmediate()))
         return jsBoolean(false);
 
-    ExecState* exec = ARG_exec;
-    JSValue* result = jsBoolean(strictEqualSlowCase(src1, src2));
-    VM_CHECK_EXCEPTION_AT_END();
-    return result;
+    return jsBoolean(strictEqualSlowCaseInline(src1, src2));
 }
 
@@ -5318 +5315 @@
     if (JSImmediate::areBothImmediate(src1, src2))
         return jsBoolean(reinterpret_cast<intptr_t>(src1) != reinterpret_cast<intptr_t>(src2));
-    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 != JSImmediate::from(0)) & (src2 != JSImmediate::from(0)))
+    if (JSImmediate::isEitherImmediate(src1, src2) & (src1 != JSImmediate::zeroImmediate()) & (src2 != JSImmediate::zeroImmediate()))
         return jsBoolean(true);
     
-    ExecState* exec = ARG_exec;
-    JSValue* result = jsBoolean(!strictEqualSlowCase(src1, src2));
-    VM_CHECK_EXCEPTION_AT_END();
-    return result;
+    return jsBoolean(!strictEqualSlowCaseInline(src1, src2));
 }