Changeset 36727 in webkit for trunk/JavaScriptCore/kjs/operations.h

Timestamp:

Sep 20, 2008, 10:54:23 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-20 Maciej Stachowiak <​[email protected]>

Reviewed by Darin.

• assorted optimizations to === and !== operators (work towards <​https://bugs.webkit.org/show_bug.cgi?id=20820>)

2.5% speedup on earley-boyer test

• VM/Machine.cpp: (JSC::Machine::cti_op_stricteq): Use inline version of strictEqualSlowCase; remove unneeded exception check. (JSC::Machine::cti_op_nstricteq): ditto
• kjs/operations.cpp: (JSC::strictEqual): Use strictEqualSlowCaseInline (JSC::strictEqualSlowCase): ditto
• kjs/operations.h: (JSC::strictEqualSlowCaseInline): Version of strictEqualSlowCase that can be inlined, since the extra function call indirection is a lose for CTI.

File:

• trunk/JavaScriptCore/kjs/operations.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/operations.h

@@ -31 +31 @@
   bool strictEqual(JSValue*, JSValue*);
   bool strictEqualSlowCase(JSValue*, JSValue*);
+
+  inline bool strictEqualSlowCaseInline(JSValue* v1, JSValue* v2)
+  {
+      ASSERT(!JSImmediate::areBothImmediate(v1, v2));
+      
+      if (JSImmediate::isEitherImmediate(v1, v2)) {
+          ASSERT(v1 == JSImmediate::zeroImmediate() || v2 == JSImmediate::zeroImmediate());
+          ASSERT(v1 != v2);
+
+          // The reason we can't just return false here is that 0 === -0,
+          // and while the former is an immediate number, the latter is not.
+          if (v1 == JSImmediate::zeroImmediate())
+              return static_cast<JSCell*>(v2)->isNumber() && static_cast<JSNumberCell*>(v2)->value() == 0;
+          return static_cast<JSCell*>(v1)->isNumber() && static_cast<JSNumberCell*>(v1)->value() == 0;
+      }
+      
+      if (static_cast<JSCell*>(v1)->isNumber()) {
+          return static_cast<JSCell*>(v2)->isNumber()
+              && static_cast<JSNumberCell*>(v1)->value() == static_cast<JSNumberCell*>(v2)->value();
+      }
+
+      if (static_cast<JSCell*>(v1)->isString()) {
+          return static_cast<JSCell*>(v2)->isString()
+              && static_cast<JSString*>(v1)->value() == static_cast<JSString*>(v2)->value();
+      }
+
+      return v1 == v2;
+  }
+
   JSValue* throwOutOfMemoryError(ExecState*);
 }