Changeset 36741 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Sep 21, 2008, 1:35:20 PM (17 years ago)

Author:

Darin Adler

Message:

2008-09-21 Judit Jasz <​[email protected]>

Reviewed and tweaked by Darin Adler.

• ​https://bugs.webkit.org/show_bug.cgi?id=20645 Elminate duplicate constant values in CodeBlocks.

Seems to be a wash on SunSpider.

• VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitLoad): Use m_numberMap and m_stringMap to guarantee we emit the same JSValue* for identical numbers and strings.
• VM/CodeGenerator.h: Added overload of emitLoad for const Identifier&. Add NumberMap and IdentifierStringMap types and m_numberMap and m_stringMap.
• kjs/nodes.cpp: (JSC::StringNode::emitCode): Call the new emitLoad and let it do the JSString creation.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -254 +254 @@
     if (dst == ignoredResult())
         return 0;
-    return generator.emitLoad(dst, jsOwnedString(generator.globalExec(), m_value.ustring()));
+    return generator.emitLoad(dst, m_value);
 }