Changeset 36764 in webkit for trunk/JavaScriptCore/kjs/StringObjectThatMasqueradesAsUndefined.h

Timestamp:

Sep 22, 2008, 6:59:06 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Dave Hyatt.

Based on initial work by Darin Adler.

• replace masqueradesAsUndefined virtual method with a flag in TypeInfo
• use this to JIT inline code for eq_null and neq_null ​https://bugs.webkit.org/show_bug.cgi?id=20823

0.5% speedup on SunSpider
~4% speedup on Richards benchmark

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/Machine.cpp: (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined):
• VM/Machine.h:
• kjs/JSCell.h:
• kjs/JSValue.h:
• kjs/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::create): (JSC::StringObjectThatMasqueradesAsUndefined::createStructureID):
• kjs/StructureID.h: (JSC::StructureID::mutableTypeInfo):
• kjs/TypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::masqueradesAsUndefined):
• kjs/operations.cpp: (JSC::equal):
• masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::setnz_r): (JSC::X86Assembler::testl_i32m):

WebCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Dave Hyatt.

Based on initial work by Darin Adler.

• replace masqueradesAsUndefined virtual method with a flag in TypeInfo
• use this to JIT inline code for eq_null and neq_null ​https://bugs.webkit.org/show_bug.cgi?id=20823

• WebCore.xcodeproj/project.pbxproj:
• WebCore.vcproj/WebCore.vcproj:
• bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
• bindings/js/JSHTMLAllCollection.cpp: Added. (WebCore::):
• bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::createStructureID): (WebCore::JSHTMLAllCollection::toBoolean):

File:

• trunk/JavaScriptCore/kjs/StringObjectThatMasqueradesAsUndefined.h (modified) (3 diffs)

trunk/JavaScriptCore/kjs/StringObjectThatMasqueradesAsUndefined.h

@@ -22 +22 @@
 #define StringObjectThatMasqueradesAsUndefined_h
 
+#include "JSGlobalObject.h"
 #include "StringObject.h"
 #include "ustring.h"
@@ -30 +31 @@
     class StringObjectThatMasqueradesAsUndefined : public StringObject {
     public:
+        static StringObjectThatMasqueradesAsUndefined* create(ExecState* exec, const UString& string)
+        {
+            return new (exec) StringObjectThatMasqueradesAsUndefined(exec,
+                createStructureID(exec->lexicalGlobalObject()->stringPrototype()), string);
+        }
+
+    private:
         StringObjectThatMasqueradesAsUndefined(ExecState* exec, PassRefPtr<StructureID> structure, const UString& string)
             : StringObject(exec, structure, string)
@@ -35 +43 @@
         }
 
-        virtual bool masqueradeAsUndefined() const { return true; }
+        static PassRefPtr<StructureID> createStructureID(JSValue* proto) 
+        { 
+            return StructureID::create(proto, TypeInfo(ObjectType, MasqueradesAsUndefined)); 
+        }
+
         virtual bool toBoolean(ExecState*) const { return false; }
     };