Changeset 36766 in webkit for trunk/JavaScriptCore/API/JSCallbackObjectFunctions.h

Timestamp:

Sep 22, 2008, 8:03:52 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag

Partial work towards <​https://bugs.webkit.org/show_bug.cgi?id=20818>

2.2% speedup on EarleyBoyer benchmark.

• API/JSCallbackConstructor.cpp:
• API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructureID):
• API/JSCallbackFunction.cpp:
• API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructureID):
• API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructureID):
• API/JSCallbackObjectFunctions.h: (JSC::::hasInstance):
• API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor):
• JavaScriptCore.exp:
• VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_instanceof):
• kjs/InternalFunction.cpp:
• kjs/InternalFunction.h: (JSC::InternalFunction::createStructureID):
• kjs/JSObject.cpp:
• kjs/JSObject.h:
• kjs/TypeInfo.h: (JSC::TypeInfo::implementsHasInstance):

WebCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag

Partial work towards <​https://bugs.webkit.org/show_bug.cgi?id=20818>

2.2% speedup on EarleyBoyer benchmark.

• bindings/js/JSQuarantinedObjectWrapper.cpp:
• bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructureID):
• bindings/scripts/CodeGeneratorJS.pm:

File:

• trunk/JavaScriptCore/API/JSCallbackObjectFunctions.h (modified) (1 diff)

trunk/JavaScriptCore/API/JSCallbackObjectFunctions.h

@@ -274 +274 @@
 
 template <class Base>
-bool JSCallbackObject<Base>::implementsHasInstance() const
-{
-    for (JSClassRef jsClass = classRef(); jsClass; jsClass = jsClass->parentClass)
-        if (jsClass->hasInstance)
-            return true;
-    
+bool JSCallbackObject<Base>::hasInstance(ExecState* exec, JSValue* value, JSValue*)
+{
+    JSContextRef execRef = toRef(exec);
+    JSObjectRef thisRef = toRef(this);
+    
+    for (JSClassRef jsClass = classRef(); jsClass; jsClass = jsClass->parentClass) {
+        if (JSObjectHasInstanceCallback hasInstance = jsClass->hasInstance) {
+            JSLock::DropAllLocks dropAllLocks(exec);
+            return hasInstance(execRef, thisRef, toRef(value), toRef(exec->exceptionSlot()));
+        }
+    }
     return false;
-}
-
-template <class Base>
-bool JSCallbackObject<Base>::hasInstance(ExecState* exec, JSValue* value, JSValue*)
-{
-    JSContextRef execRef = toRef(exec);
-    JSObjectRef thisRef = toRef(this);
-    
-    for (JSClassRef jsClass = classRef(); jsClass; jsClass = jsClass->parentClass) {
-        if (JSObjectHasInstanceCallback hasInstance = jsClass->hasInstance) {
-            JSLock::DropAllLocks dropAllLocks(exec);
-            return hasInstance(execRef, thisRef, toRef(value), toRef(exec->exceptionSlot()));
-        }
-    }
-    ASSERT_NOT_REACHED(); // implementsHasInstance should prevent us from reaching here
-    return 0;
 }