Changeset 36766 in webkit for trunk/JavaScriptCore/VM/Machine.cpp

Timestamp:

Sep 22, 2008, 8:03:52 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag

Partial work towards <​https://bugs.webkit.org/show_bug.cgi?id=20818>

2.2% speedup on EarleyBoyer benchmark.

• API/JSCallbackConstructor.cpp:
• API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructureID):
• API/JSCallbackFunction.cpp:
• API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructureID):
• API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructureID):
• API/JSCallbackObjectFunctions.h: (JSC::::hasInstance):
• API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor):
• JavaScriptCore.exp:
• VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_instanceof):
• kjs/InternalFunction.cpp:
• kjs/InternalFunction.h: (JSC::InternalFunction::createStructureID):
• kjs/JSObject.cpp:
• kjs/JSObject.h:
• kjs/TypeInfo.h: (JSC::TypeInfo::implementsHasInstance):

WebCore:

2008-09-22 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag

Partial work towards <​https://bugs.webkit.org/show_bug.cgi?id=20818>

2.2% speedup on EarleyBoyer benchmark.

• bindings/js/JSQuarantinedObjectWrapper.cpp:
• bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructureID):
• bindings/scripts/CodeGeneratorJS.pm:

File:

• trunk/JavaScriptCore/VM/Machine.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/Machine.cpp

@@ -2124 +2124 @@
 
         JSObject* baseObj = static_cast<JSObject*>(baseVal);
-        r[dst] = jsBoolean(baseObj->implementsHasInstance() ? baseObj->hasInstance(exec, r[value].jsValue(exec), r[baseProto].jsValue(exec)) : false);
+        r[dst] = jsBoolean(baseObj->structureID()->typeInfo().implementsHasInstance() ? baseObj->hasInstance(exec, r[value].jsValue(exec), r[baseProto].jsValue(exec)) : false);
 
         ++vPC;
@@ -4305 +4305 @@
     JSObject* baseObj = static_cast<JSObject*>(baseVal);
     JSValue* basePrototype = ARG_src3;
-    JSValue* result = jsBoolean(baseObj->implementsHasInstance() ? baseObj->hasInstance(exec,  ARG_src1, basePrototype) : false);
+    JSValue* result = jsBoolean(baseObj->structureID()->typeInfo().implementsHasInstance() ? baseObj->hasInstance(exec,  ARG_src1, basePrototype) : false);
     VM_CHECK_EXCEPTION_AT_END();
     return result;