Changeset 36778 in webkit for trunk/JavaScriptCore/kjs/JSArray.h

Timestamp:

Sep 22, 2008, 2:04:45 PM (17 years ago)

Author:

Darin Adler

Message:

2008-09-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• ​https://bugs.webkit.org/show_bug.cgi?id=20993 Array.push/pop need optimized cases for JSArray

3% or so speedup on DeltaBlue benchmark.

• kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncPop): Call JSArray::pop when appropriate. (JSC::arrayProtoFuncPush): Call JSArray::push when appropriate.

• kjs/JSArray.cpp: (JSC::JSArray::putSlowCase): Set m_fastAccessCutoff when appropriate, getting us into the fast code path. (JSC::JSArray::pop): Added. (JSC::JSArray::push): Added.
• kjs/JSArray.h: Added push and pop.

• kjs/operations.cpp: (JSC::throwOutOfMemoryError): Don't inline this. Helps us avoid PIC branches.

File:

• trunk/JavaScriptCore/kjs/JSArray.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/JSArray.h

@@ -58 +58 @@
         void sort(ExecState*, JSValue* compareFunction, CallType, const CallData&);
 
+        void push(ExecState*, JSValue*);
+        JSValue* pop();
+
         bool canGetIndex(unsigned i) { return i < m_fastAccessCutoff; }
         JSValue* getIndex(unsigned i)