Changeset 36779 in webkit for trunk/JavaScriptCore/kjs/Arguments.cpp

Timestamp:

Sep 22, 2008, 2:20:52 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-09-22 Sam Weinig <​[email protected]>

Reviewed by Darin Adler.

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=20982
Speed up the apply method of functions by special-casing array and 'arguments' objects

1% speedup on v8-raytrace.

Test: fast/js/function-apply.html

• kjs/Arguments.cpp: (JSC::Arguments::fillArgList):
• kjs/Arguments.h:
• kjs/FunctionPrototype.cpp: (JSC::functionProtoFuncApply):
• kjs/JSArray.cpp: (JSC::JSArray::fillArgList):
• kjs/JSArray.h:

LayoutTests:

2008-09-22 Sam Weinig <​[email protected]>

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=20982

• fast/js/function-apply-expected.txt: Added.
• fast/js/function-apply.html: Added.
• fast/js/resources/function-apply.js: Added.

File:

• trunk/JavaScriptCore/kjs/Arguments.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/Arguments.cpp

@@ -92 +92 @@
 }
 
+void Arguments::fillArgList(ExecState* exec, ArgList& args)
+{
+    if (!d->deletedArguments) {
+        if (d->numParameters == d->numArguments) {
+            args.initialize(&d->activation->registerAt(d->firstArgumentIndex), d->numArguments);
+            return;
+        }
+
+        unsigned parametersLength = min(d->numParameters, d->numArguments);
+        unsigned i = 0;
+        for (; i < parametersLength; ++i)
+            args.append(d->activation->uncheckedSymbolTableGetValue(d->firstArgumentIndex + i));
+        for (; i < d->numArguments; ++i)
+            args.append(d->extraArguments[i - d->numParameters]);
+        return;
+    }
+
+    unsigned parametersLength = min(d->numParameters, d->numArguments);
+    unsigned i = 0;
+    for (; i < parametersLength; ++i) {
+        if (!d->deletedArguments[i])
+            args.append(d->activation->uncheckedSymbolTableGetValue(d->firstArgumentIndex + i));
+        else
+            args.append(get(exec, i));
+    }
+    for (; i < d->numArguments; ++i) {
+        if (!d->deletedArguments[i])
+            args.append(d->extraArguments[i - d->numParameters]);
+        else
+            args.append(get(exec, i));
+    }
+}
+
 bool Arguments::getOwnPropertySlot(ExecState* exec, unsigned i, PropertySlot& slot)
 {