Changeset 36794 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Sep 22, 2008, 10:22:22 PM (17 years ago)

Author:

Darin Adler

Message:

2008-09-22 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• ​https://bugs.webkit.org/show_bug.cgi?id=21019 make FunctionBodyNode::ref/deref fast

Speeds up v8-raytrace by 7.2%.

• kjs/nodes.cpp: (JSC::FunctionBodyNode::FunctionBodyNode): Initialize m_refCount to 0.
• kjs/nodes.h: (JSC::FunctionBodyNode::ref): Call base class ref once, and thereafter use m_refCount. (JSC::FunctionBodyNode::deref): Ditto, but the deref side.

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes.h

@@ -2270 +2270 @@
         void setSource(const SourceRange& source) { m_source = source; } 
         UString toSourceString() const JSC_FAST_CALL { return UString("{") + m_source.toString() + UString("}"); }
+
+        // These objects are ref/deref'd a lot in the scope chain, so this is a faster ref/deref.
+        // If the virtual machine changes so this doesn't happen as much we can change back.
+        void ref()
+        {
+            if (++m_refCount == 1)
+                ScopeNode::ref();
+        }
+        void deref()
+        {
+            ASSERT(m_refCount);
+            if (!--m_refCount)
+                ScopeNode::deref();
+        }
+
     protected:
         FunctionBodyNode(JSGlobalData*, SourceElements*, VarStack*, FunctionStack*, bool usesEval, bool needsClosure, int numConstants) JSC_FAST_CALL;
@@ -2280 +2295 @@
         OwnPtr<CodeBlock> m_code;
         SourceRange m_source;
+        unsigned m_refCount;
     };