Changeset 36805 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Sep 23, 2008, 6:20:23 AM (17 years ago)

Author:

[email protected]

Message:

2008-09-23 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• inline the fast cases of !==, same as for ===

2.9% speedup on EarleyBoyer benchmark

• VM/CTI.cpp: (JSC::CTI::compileOpStrictEq): Factored stricteq codegen into this function, and parameterized so it can do the reverse version as well. (JSC::CTI::privateCompileMainPass): Use the above for stricteq and nstricteq.
• VM/CTI.h: (JSC::CTI::): Declare above stuff.
• VM/Machine.cpp: (JSC::Machine::cti_op_nstricteq): Removed fast cases, now handled inline.

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -523 +523 @@
 }
 
+void CTI::compileOpStrictEq(Instruction* instruction, unsigned i, CompileOpStrictEqType type)
+{
+    bool negated = (type == OpNStrictEq);
+
+    unsigned dst = instruction[i + 1].u.operand;
+    unsigned src1 = instruction[i + 2].u.operand;
+    unsigned src2 = instruction[i + 3].u.operand;
+
+    emitGetArg(src1, X86::eax);
+    emitGetArg(src2, X86::edx);
+
+    m_jit.testl_i32r(JSImmediate::TagMask, X86::eax);
+    X86Assembler::JmpSrc firstNotImmediate = m_jit.emitUnlinkedJe();
+    m_jit.testl_i32r(JSImmediate::TagMask, X86::edx);
+    X86Assembler::JmpSrc secondNotImmediate = m_jit.emitUnlinkedJe();
+
+    m_jit.cmpl_rr(X86::edx, X86::eax);
+    if (negated)
+        m_jit.setne_r(X86::eax);
+    else
+        m_jit.sete_r(X86::eax);
+    m_jit.movzbl_rr(X86::eax, X86::eax);
+    emitTagAsBoolImmediate(X86::eax);
+            
+    X86Assembler::JmpSrc bothWereImmediates = m_jit.emitUnlinkedJmp();
+
+    m_jit.link(firstNotImmediate, m_jit.label());
+
+    // check that edx is immediate but not the zero immediate
+    m_jit.testl_i32r(JSImmediate::TagMask, X86::edx);
+    m_jit.setz_r(X86::ecx);
+    m_jit.movzbl_rr(X86::ecx, X86::ecx); // ecx is now 1 if edx was nonimmediate
+    m_jit.cmpl_i32r(reinterpret_cast<uint32_t>(JSImmediate::zeroImmediate()), X86::edx);
+    m_jit.sete_r(X86::edx);
+    m_jit.movzbl_rr(X86::edx, X86::edx); // edx is now 1 if edx was the 0 immediate
+    m_jit.orl_rr(X86::ecx, X86::edx);
+
+    m_slowCases.append(SlowCaseEntry(m_jit.emitUnlinkedJnz(), i));
+
+    m_jit.movl_i32r(reinterpret_cast<uint32_t>(jsBoolean(negated)), X86::eax);
+
+    X86Assembler::JmpSrc firstWasNotImmediate = m_jit.emitUnlinkedJmp();
+
+    m_jit.link(secondNotImmediate, m_jit.label());
+    // check that eax is not the zero immediate (we know it must be immediate)
+    m_jit.cmpl_i32r(reinterpret_cast<uint32_t>(JSImmediate::zeroImmediate()), X86::eax);
+    m_slowCases.append(SlowCaseEntry(m_jit.emitUnlinkedJe(), i));
+
+    m_jit.movl_i32r(reinterpret_cast<uint32_t>(jsBoolean(negated)), X86::eax);
+
+    m_jit.link(bothWereImmediates, m_jit.label());
+    m_jit.link(firstWasNotImmediate, m_jit.label());
+
+    emitPutResult(dst);
+}
+
 void CTI::emitSlowScriptCheck(unsigned opcodeIndex)
 {
@@ -1392 +1448 @@
         CTI_COMPILE_UNARY_OP(op_is_object)
         CTI_COMPILE_UNARY_OP(op_is_function)
-        CTI_COMPILE_BINARY_OP(op_nstricteq)
         case op_stricteq: {
-            unsigned dst = instruction[i + 1].u.operand;
-            unsigned src1 = instruction[i + 2].u.operand;
-            unsigned src2 = instruction[i + 3].u.operand;
-
-            emitGetArg(src1, X86::eax);
-            emitGetArg(src2, X86::edx);
-
-            m_jit.testl_i32r(JSImmediate::TagMask, X86::eax);
-            X86Assembler::JmpSrc firstNotImmediate = m_jit.emitUnlinkedJe();
-            m_jit.testl_i32r(JSImmediate::TagMask, X86::edx);
-            X86Assembler::JmpSrc secondNotImmediate = m_jit.emitUnlinkedJe();
-
-            m_jit.cmpl_rr(X86::edx, X86::eax);
-            m_jit.sete_r(X86::eax);
-            m_jit.movzbl_rr(X86::eax, X86::eax);
-            emitTagAsBoolImmediate(X86::eax);
-            
-            X86Assembler::JmpSrc bothWereImmediates = m_jit.emitUnlinkedJmp();
-
-            m_jit.link(firstNotImmediate, m_jit.label());
-
-            // check that edx is immediate but not the zero immediate
-            
-            m_jit.testl_i32r(JSImmediate::TagMask, X86::edx);
-            m_jit.setz_r(X86::ecx);
-            m_jit.movzbl_rr(X86::ecx, X86::ecx); // ecx is now 1 if edx was nonimmediate
-            m_jit.cmpl_i32r(reinterpret_cast<uint32_t>(JSImmediate::zeroImmediate()), X86::edx);
-            m_jit.sete_r(X86::edx);
-            m_jit.movzbl_rr(X86::edx, X86::edx); // edx is now 1 if edx was the 0 immediate
-            m_jit.orl_rr(X86::ecx, X86::edx);
-
-            m_slowCases.append(SlowCaseEntry(m_jit.emitUnlinkedJnz(), i));
-
-            m_jit.movl_i32r(reinterpret_cast<uint32_t>(jsBoolean(false)), X86::eax);
-
-            X86Assembler::JmpSrc firstWasNotImmediate = m_jit.emitUnlinkedJmp();
-
-            m_jit.link(secondNotImmediate, m_jit.label());
-            // check that eax is not the zero immediate (we know it must be immediate)
-            m_jit.cmpl_i32r(reinterpret_cast<uint32_t>(JSImmediate::zeroImmediate()), X86::eax);
-            m_slowCases.append(SlowCaseEntry(m_jit.emitUnlinkedJe(), i));
-
-            m_jit.movl_i32r(reinterpret_cast<uint32_t>(jsBoolean(false)), X86::eax);
-
-            m_jit.link(bothWereImmediates, m_jit.label());
-            m_jit.link(firstWasNotImmediate, m_jit.label());
-
-            emitPutResult(dst);
-            
+            compileOpStrictEq(instruction, i, OpStrictEq);
+            i += 4;
+            break;
+        }
+        case op_nstricteq: {
+            compileOpStrictEq(instruction, i, OpNStrictEq);
             i += 4;
             break;