Changeset 36871 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Sep 24, 2008, 3:19:05 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-24 Kevin McCullough <​[email protected]>

Reviewed by Geoff.

Bug 21031: Breakpoints in the condition of loops only breaks the first
time

• Now when setting breakpoints in the condition of a loop (for, while, for in, and do while) will successfully break each time throught the loop.
• For 'for' loops we need a little more complicated behavior that cannot be accomplished without some more significant changes: ​https://bugs.webkit.org/show_bug.cgi?id=21073

• kjs/nodes.cpp: (JSC::statementListEmitCode): We don't want to blindly emit a debug hook at the first line of loops, instead let the loop emit the debug hooks. (JSC::DoWhileNode::emitCode): (JSC::WhileNode::emitCode): (JSC::ForNode::emitCode): (JSC::ForInNode::emitCode):
• kjs/nodes.h: (JSC::StatementNode::): (JSC::DoWhileNode::): (JSC::WhileNode::): (JSC::ForInNode::):

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (5 diffs)

trunk/JavaScriptCore/kjs/nodes.h

@@ -235 +235 @@
 
         virtual bool isBlock() const JSC_FAST_CALL { return false; }
-        virtual bool isDoWhile() const JSC_FAST_CALL { return false; }
+        virtual bool isLoop() const JSC_FAST_CALL { return false; }
     protected:
         LabelStack m_labelStack;
@@ -1938 +1938 @@
         virtual void streamTo(SourceStream&) const JSC_FAST_CALL;
 
-        virtual bool isDoWhile() const JSC_FAST_CALL { return true; }
+        virtual bool isLoop() const JSC_FAST_CALL { return true; }
     private:
         RefPtr<StatementNode> m_statement;
@@ -1956 +1956 @@
         virtual void streamTo(SourceStream&) const JSC_FAST_CALL;
 
+        virtual bool isLoop() const JSC_FAST_CALL { return true; }
     private:
         RefPtr<ExpressionNode> m_expr;
@@ -1977 +1978 @@
         virtual void streamTo(SourceStream&) const JSC_FAST_CALL;
 
+        virtual bool isLoop() const JSC_FAST_CALL { return true; }
     private:
         RefPtr<ExpressionNode> m_expr1;
@@ -1993 +1995 @@
         virtual void streamTo(SourceStream&) const JSC_FAST_CALL;
 
+        virtual bool isLoop() const JSC_FAST_CALL { return true; }
     private:
         Identifier m_ident;