Changeset 36876 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Sep 24, 2008, 5:26:38 PM (17 years ago)

Author:

[email protected]

Message:

2008-09-24 Maciej Stachowiak <​[email protected]>

Reviewed by Oliver Hunt.

• inline JIT fast case of op_neq
• remove extra level of function call indirection from slow cases of eq and neq

1% speedup on Richards

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
• VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_neq):
• kjs/operations.cpp: (JSC::equal): (JSC::equalSlowCase):
• kjs/operations.h: (JSC::equalSlowCaseInline):

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -1418 +1418 @@
         }
         CTI_COMPILE_BINARY_OP(op_less)
-        CTI_COMPILE_BINARY_OP(op_neq)
+        case op_neq: {
+            emitGetArg(instruction[i + 2].u.operand, X86::eax);
+            emitGetArg(instruction[i + 3].u.operand, X86::edx);
+            emitJumpSlowCaseIfNotImmNums(X86::eax, X86::edx, i);
+            m_jit.cmpl_rr(X86::eax, X86::edx);
+
+            m_jit.setne_r(X86::eax);
+            m_jit.movzbl_rr(X86::eax, X86::eax);
+            emitTagAsBoolImmediate(X86::eax);
+
+            emitPutResult(instruction[i + 1].u.operand);
+
+            i += 4;
+            break;
+        }
         case op_post_dec: {
             int srcDst = instruction[i + 2].u.operand;
@@ -2179 +2193 @@
             break;
         }
+        case op_neq: {
+            m_jit.link(iter->from, m_jit.label());
+            emitPutArg(X86::eax, 0);
+            emitPutArg(X86::edx, 4);
+            emitCall(i, Machine::cti_op_neq);
+            emitPutResult(instruction[i + 1].u.operand);
+            i += 4;
+            break;
+        }
         CTI_COMPILE_BINARY_OP_SLOW_CASE(op_stricteq);
         CTI_COMPILE_BINARY_OP_SLOW_CASE(op_nstricteq);