Changeset 37088 in webkit for trunk/JavaScriptCore/kjs/JSGlobalObject.h

Timestamp:

Sep 29, 2008, 6:14:26 PM (17 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

2008-09-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• ​https://bugs.webkit.org/show_bug.cgi?id=21214 work on getting rid of ExecState

• JavaScriptCore.exp: Updated since JSGlobalObject::init no longer takes a parameter.

• VM/Machine.cpp: (JSC::Machine::execute): Removed m_registerFile argument for ExecState constructors.

• kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Removed globalThisValue argument for ExecState constructor.

• kjs/ExecState.cpp: (JSC::ExecState::ExecState): Removed globalThisValue and registerFile arguments to constructors.

• kjs/ExecState.h: Removed m_globalThisValue and m_registerFile data members.

• kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Removed globalThisValue argument for ExecState constructor.

• kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): Got rid of parameter for the init function.

WebCore:

2008-09-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

• ​https://bugs.webkit.org/show_bug.cgi?id=21214 work on getting rid of ExecState

• bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument for base class constructor.

File:

• trunk/JavaScriptCore/kjs/JSGlobalObject.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSGlobalObject.h

@@ -149 +149 @@
             : JSVariableObject(globalData->nullProtoStructureID, new JSGlobalObjectData(this, this))
         {
-            init(this);
+            init();
         }
 
     protected:
-        JSGlobalObject(PassRefPtr<StructureID> structure, JSGlobalObjectData* data, JSObject* globalThisValue)
+        JSGlobalObject(PassRefPtr<StructureID> structure, JSGlobalObjectData* data)
             : JSVariableObject(structure, data)
         {
-            init(globalThisValue);
+            init();
         }
 
@@ -271 +271 @@
 
     private:
-        // FIXME: Fold these functions into the constructor.
-        void init(JSObject* thisValue);
+        // FIXME: Fold reset into init.
+        void init();
         void reset(JSValue* prototype);